[PATCH] D58689: [scudo][standalone] Add a standalone vector class
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 26 15:40:47 PST 2019
vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lib/scudo/standalone/vector.h:111
+ return false;
+ return memcmp(Lhs.data(), Rhs.data(), Lhs.size() * sizeof(T)) == 0;
+}
----------------
memcmp here does not look right (as in sanitizer common), as documented it works only for POD
if you don't need these operators, maybe it's safe just to remove them
Repository:
rCRT Compiler Runtime
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58689/new/
https://reviews.llvm.org/D58689
More information about the llvm-commits
mailing list