[PATCH] D58677: [llvm-readobj]Add additional testing for various ELF features

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 26 21:40:15 PST 2019


rupprecht accepted this revision.
rupprecht added a comment.
This revision is now accepted and ready to land.

I always like having more tests :D



================
Comment at: test/tools/llvm-readobj/elf-dynamic-no-PT_DYNAMIC.test:1
+# Show that no dumping occurs if there is no PT_DYNAMIC header.
+# RUN: yaml2obj %s -o %t.no-phdr
----------------
nit: it seems like uppercase filenames are rarely used, "elf-dynamic-no-pt-dynamic.test" might be better
Same with the other pt_dynamic test


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58677/new/

https://reviews.llvm.org/D58677





More information about the llvm-commits mailing list