[PATCH] D58677: [llvm-readobj]Add additional testing for various ELF features

Xing via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 26 20:27:56 PST 2019


Higuoxing added inline comments.


================
Comment at: test/tools/llvm-readobj/elf-malformed-PT_DYNAMIC.test:16-17
+# RUN: cp %t.stripped %t.truncated1
+# RUN: %python -c "with open(r'%t.truncated', 'r+') as f: f.truncate(0x1001)"
+# RUN: not llvm-readobj %t.truncated --dynamic-table 2>&1 | FileCheck %s
+
----------------
Here should be
```
# RUN: %python -c "with open(r'%t.truncated1', 'r+') as f: f.truncate(0x1001)"
                                           ^
# RUN: not llvm-readobj %t.truncated1 --dynamic-table 2>&1 | FileCheck %s
                                    ^
```
right?


================
Comment at: test/tools/llvm-readobj/elf-malformed-PT_DYNAMIC.test:22
+# RUN: %python -c "with open(r'%t.truncated', 'r+') as f: f.truncate(0xFFF)"
+# RUN: not llvm-readobj %t.truncated --dynamic-table 2>&1 | FileCheck %s
+
----------------
Here should be
```
# RUN: %python -c "with open(r'%t.truncated2', 'r+') as f: f.truncate(0x1001)"
                                           ^
# RUN: not llvm-readobj %t.truncated2 --dynamic-table 2>&1 | FileCheck %s
                                    ^
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58677/new/

https://reviews.llvm.org/D58677





More information about the llvm-commits mailing list