[PATCH] D56046: Output ELF files after ThinLTO is run.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 26 09:37:18 PST 2019


pcc accepted this revision.
pcc added a comment.

LGTM



================
Comment at: test/ELF/lto/obj-path.ll:13
+; RUN: llvm-nm %t4.o1 2>&1 | FileCheck %s -check-prefix=SYMBOLS
+; RUN: llvm-nm %t4.o2 2>&1 | FileCheck %p/Inputs/obj-path.ll -check-prefix=SYMBOLS
+
----------------
We don't normally split check lines into multiple files like this. Can you move the check line for `SYMBOLS` from the other file into this one (and remove the one for `ELF` since it is unused)?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56046/new/

https://reviews.llvm.org/D56046





More information about the llvm-commits mailing list