[PATCH] D58534: [WIP] dsymutil support for DW_OP_convert

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 26 09:34:00 PST 2019


aprantl added a comment.

Thanks for pointing out that DW_OP_convert isn't the only operation that uses a CU-relative type DIE offset!
I went through the DWARF 5 spec once more and it looks like all the operations that require a type parameter also require that that type parameter is a basic type. Since basic types are tiny, we can just keep them all unconditionally and skip the entire scanExpressionDIERefs part. With this change dsymutil gets more than 2 seconds faster on clang, basically almost the original performance.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58534/new/

https://reviews.llvm.org/D58534





More information about the llvm-commits mailing list