[PATCH] D58534: [WIP] dsymutil support for DW_OP_convert

[Markus Lavin via Phabricator via llvm-commits]

markus added inline comments.


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:723
+  for (auto &Op : Expression) {
+    if (Op.getCode() == dwarf::DW_OP_convert) {
+      assert(OpOffset < Op.getEndOffset());
----------------
Check if `DWARFExpression::Operation::Encoding` is `BaseTypeRef` instead.


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:1151
+  for (auto &Op : Expression) {
+    if (Op.getCode() == dwarf::DW_OP_convert) {
+      assert(OpOffset < Op.getEndOffset());
----------------
Instead of checking for `DW_OP_convert` explicitly we could check the `DWARFExpression::Operation::Encoding` to see if it is `BaseTypeRef`. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58534/new/

https://reviews.llvm.org/D58534