[PATCH] D58538: [DebugInfo] Add source attributes for function declaration on behalf of owner CU

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 25 17:15:05 PST 2019


dblaikie added inline comments.


================
Comment at: test/DebugInfo/X86/template_function_decl.ll:12
+;   int foo;
+;   template <class T> T squared(T val) { return val * val; }
+; };
----------------
Could probably remove the parameter and logic in this (just "template<typename T> void templ() { }")


================
Comment at: test/DebugInfo/X86/template_function_decl.ll:30
+; struct S gs_bar;
+; struct S2 gs2_bar;
+; int bar(int v) {
----------------
What purpose does S2 serve in this test case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58538/new/

https://reviews.llvm.org/D58538





More information about the llvm-commits mailing list