[PATCH] D58538: [DebugInfo] Add source attributes for function declaration on behalf of owner CU

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 updated this revision to Diff 188104.
evgeny777 added a comment.

> I think the point where we lookup the other CU and cross over to it should probably be earlier - imagine if all attributes could potentially be CU-local (eg: we could produce a separate string_offsets section for each CU and so have separate strx indexes for each CU) & we should probably have a solution that would be correct in that situation. Does that make sense?

This probably makes sense, I moved this lookup earlier, so now all subprogram attributes are applied on behalf of owner unit. This should address the problem you described.

> Also, it's helpful to include example source code in the IR file to demonstrate roughly what the LLVM IR metadata is representing/how it was produced in case it needs to be updated at a later date (it's a bit hard to manually edit the LLVM IR).

I've added it as comments to IR file and also uploading source archive in case you want to try it yourself
F8341736: dist.tbz2 <https://reviews.llvm.org/F8341736>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58538/new/

https://reviews.llvm.org/D58538

Files:
  include/llvm/CodeGen/DIE.h
  lib/CodeGen/AsmPrinter/DIE.cpp
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  test/DebugInfo/X86/template_function_decl.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58538.188104.patch
Type: text/x-patch
Size: 9448 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190225/0d58454b/attachment.bin>