[PATCH] D54697: [llvm-objdump] Add `Version References` dumper

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

This looks fine, thanks! (with a minor nit addressed)
Let's see if anyone else has comments.



================
Comment at: tools/llvm-objdump/ELFDump.cpp:303
+template <class ELFT>
+void printSymbolVersionInfo(const ELFFile<ELFT> *Elf, StringRef FileName) {
+  typedef typename ELFT::Shdr Elf_Shdr;
----------------
Higuoxing wrote:
> grimar wrote:
> > Shouldn't you be able to get `Filename` from `Elf`?
> Sorry, I cannot find a `getFileName()` method in `Elf` or something else like that.
Yeah, I see now. Nevermind, I looked at the wrong class I think.


================
Comment at: tools/llvm-objdump/ELFDump.cpp:326
+
+    if (Shdr.sh_type == ELF::SHT_GNU_verneed)
+      printSymbolVersionDependency<ELFT>(*ContentsOrError, *StrTabOrError);
----------------
You do not need this `if`, this condition is always true now.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54697/new/

https://reviews.llvm.org/D54697