[PATCH] D54697: [llvm-objdump] Add `Version References` dumper

[Xing via Phabricator via llvm-commits]

Higuoxing marked 3 inline comments as done.
Higuoxing added inline comments.


================
Comment at: tools/llvm-objdump/ELFDump.cpp:303
+template <class ELFT>
+void printSymbolVersionInfo(const ELFFile<ELFT> *Elf, StringRef FileName) {
+  typedef typename ELFT::Shdr Elf_Shdr;
----------------
grimar wrote:
> Shouldn't you be able to get `Filename` from `Elf`?
Sorry, I cannot find a `getFileName()` method in `Elf` or something else like that.


================
Comment at: tools/llvm-objdump/ELFDump.cpp:313
+        Shdr.sh_type != ELF::SHT_GNU_verneed)
+      continue;
+
----------------
grimar wrote:
> grimar wrote:
> > If you're not going to implement `SHT_GNU_verneed` in this patch then I think you should
> > get rid of `Shdr.sh_type != ELF::SHT_GNU_verneed`.
> I meant "if you're not going to implement `ELF::SHT_GNU_verdef`" of course..
Thanks for reviewing, I would like to implement it in next patch :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54697/new/

https://reviews.llvm.org/D54697