[PATCH] D58575: [WebAssembly] Fix select of and (PR40805)

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 23 07:13:52 PST 2019


tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.

Thanks for tracking that down. You’re totally right that the pattern was wrong generally, although it still applies to legalized i1s. Since we don’t have access to legalization history in selection dags, I think we will want to reintroduce this optimization more selectively in WebAssemblyISelDAGLowering.

Feel free to commit this, or let me know if you don’t have commit privileges and I can land it for you.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58575/new/

https://reviews.llvm.org/D58575





More information about the llvm-commits mailing list