[PATCH] D58575: [WebAssembly] Fix select of and (PR40805)

[Nikita Popov via Phabricator via llvm-commits]

nikic created this revision.
nikic added a reviewer: tlively.
Herald added subscribers: llvm-commits, sunfish, aheejin, jgravelle-google, sbc100, dschuff.
Herald added a project: LLVM.

Fixes https://bugs.llvm.org/show_bug.cgi?id=40805 introduced by patterns added in D53676 <https://reviews.llvm.org/D53676>.

I'm removing the patterns entirely here, as they are not correct in the general case, but maybe they still can/need to be salvaged for more specific cases. I'm not sure whether or not the code that was previously generated for non-zeroext i1 params was correct -- I couldn't find information on what the semantics of an i1 parameter without zeroext/signext is. My guess is that it is anyext by default, which means that the explicit masking is necessary there for correctness.


Repository:
  rL LLVM

https://reviews.llvm.org/D58575

Files:
  lib/Target/WebAssembly/WebAssemblyInstrInteger.td
  test/CodeGen/WebAssembly/select.ll
  test/CodeGen/WebAssembly/simd-select.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58575.188037.patch
Type: text/x-patch
Size: 5291 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190223/5561fdea/attachment.bin>