[PATCH] D55283: CodeGen: Refactor regallocator command line and target selection

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: include/llvm/CodeGen/TargetPassConfig.h:438
+  /// and rewriting. \returns true if any passes were added.
+  virtual bool addRegAssignmentFast();
+  virtual bool addRegAssignmentOptimized();
----------------
Should the hook says Assignment *and* rewriting?


================
Comment at: lib/CodeGen/TargetPassConfig.cpp:903
+    addFastRegAlloc();
   }
 
----------------
No braces


================
Comment at: lib/CodeGen/TargetPassConfig.cpp:1115
+  // kill markers.
+  addPass(&StackSlotColoringID);
+
----------------
Where do you draw the line of which pass to pull in that method?
In particular, why pull StackSlotColoring and not MachineCopyPropagation for instance.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55283/new/

https://reviews.llvm.org/D55283