[PATCH] D47735: [DAGCombiner] Create rotates more aggressively

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I think the general approach is still fine.  Given we have funnel shifts, we might want to reassociate to form funnel shifts, rather than just rotates, on targets which have native funnel shift instructions.  (We'd still want to prefer rotates where possible, I think.)



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4914
+    if (Opc == ISD::SHL || Opc == ISD::SRL)
+      OpMap[V.getOperand(0)->getIROrder()].push_back(I);
+  }
----------------
getNodeId()?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47735/new/

https://reviews.llvm.org/D47735