[PATCH] D47735: [DAGCombiner] Create rotates more aggressively

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D47735#1406249 <https://reviews.llvm.org/D47735#1406249>, @kparzysz wrote:

> Are you opposed to having this done in the DAG combiner?


Looking back at the comments from July 2018 - we have completed most of those tasks (in particular, we don't just expand the intrinsics now). So I think it would be nicer to get this part done with 'opt -reassociate', but I can't commit to doing that work myself immediately, so I can't be too opposed. :)

@efriedma - you started reviewing this, so I assume you're ok with a DAG patch. Does the introduction of the funnel shift intrinsics change your opinion of the implementation strategy?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47735/new/

https://reviews.llvm.org/D47735