[PATCH] D58524: [LoopSimplifyCFG] Update MemorySSA after r353911.

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 21 11:43:20 PST 2019


asbirlea created this revision.
asbirlea added reviewers: mkazantsev, rtereshin.
Herald added subscribers: george.burgess.iv, Prazek, jlebar, sanjoy.
Herald added a project: LLVM.

MemorySSA is not properly updated in LoopSimplifyCFG after recent changes. Use SplitBlock utility to resolve that and clear all updates once handleDeadExits is finished.
All updates that follow are removal of edges which are safe to handle via the removeEdge() API.
Also, deleting dead blocks is done correctly as is, i.e. delete from MemorySSA before updating the CFG and DT.


Repository:
  rL LLVM

https://reviews.llvm.org/D58524

Files:
  lib/Transforms/Scalar/LoopSimplifyCFG.cpp
  test/Transforms/LoopSimplifyCFG/constant-fold-branch.ll
  test/Transforms/LoopSimplifyCFG/lcssa.ll
  test/Transforms/LoopSimplifyCFG/live_block_marking.ll
  test/Transforms/LoopSimplifyCFG/mssa_update.ll
  test/Transforms/LoopSimplifyCFG/update_parents.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58524.187833.patch
Type: text/x-patch
Size: 14536 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190221/c5d49a1d/attachment-0001.bin>


More information about the llvm-commits mailing list