[PATCH] D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added inline comments.


================
Comment at: tools/llvm-objcopy/CopyConfig.cpp:502
+
+  if (auto *Arg = InputArgs.getLastArg(OBJCOPY_change_start)) {
+    auto EIncr = getAsInteger<int64_t>(Arg->getValue());
----------------
Is --set-start X --change-start Y valid? Should set start to X+Y, or EAddr+Y, or be an error?
It looks like this sets it to EAddr+Y, but I think it should probably be an error or X+Y.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58173/new/

https://reviews.llvm.org/D58173