[PATCH] D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/change-entry-point.test:24
+# --adjust-start is an alias for --change-start
+# RUN: llvm-objcopy --adjust-start -128 %t %t11
+# RUN: llvm-readobj --file-headers %t11 | FileCheck %s --check-prefix=SUB
----------------
When testing aliases, we've tended to run the same run twice, and then compared the output to show it is identical. I think that you should do the same here, i.e. run `--change-start -128` then compare that to `--adjust-start -128`.


================
Comment at: tools/llvm-objcopy/CopyConfig.h:105
+  // ELF entry point address expression. Input parameter is an entry point
+  // address in input ELF file. Entry address in output file is calculated
+  // with EntryExpr(input_address), when either --set-start or --change-start
----------------
Couple of nits here:
1) "in input ELF file" -> "in the input ELF file"
2) "Entry address in output file" -> "The entry address in the output file"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58173/new/

https://reviews.llvm.org/D58173