[PATCH] D56005: [RFC] [LLVM] Allocatable Global Register Variables for ARM

[Carey Williams via Phabricator via llvm-commits]

carwil added a comment.

Not at all, thank you your comments.

I believe we have handled the r7/11 (FP) case when using clang (clang patch: https://reviews.llvm.org/D56003). We throw a warning here, as even specifying -fomit-frame-pointer can't seem to *guarantee* that the compiler won't touch them. We could restrict its usage entirely, but on thumb at least, that wouldn't leave you with much choice.

I think the R6 <https://reviews.llvm.org/source/compiler-rt/>/BP problem was resolved in my last diff by disabling the BP (lib/Target/ARM/ARMBaseRegisterInfo.cpp, line 416), when r6 has been reserved.

That said, if you used LLVM directly, without clang... Yes, we will need (a) warning(s) in the backend as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56005/new/

https://reviews.llvm.org/D56005