[PATCH] D58433: AddressSanitizer: fix for SPARC with GCC

[Eric Botcazou via Phabricator via llvm-commits]

ebotcazou added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_globals.cc:115
     if (flags()->report_globals >= 2)
       ReportGlobal(g, "Search");
----------------
vitalybuka wrote:
> Could you please upload patches with "arc" tool https://llvm.org/docs/Phabricator.html#subversion-and-arcanist-deprecated
> Without it we have "Context not available."
> 
No, sorry, I don't have arcanist handy.



================
Comment at: compiler-rt/lib/asan/asan_globals.cc:118
     if (IsAddressNearGlobal(addr, g)) {
+#if defined(__GNUC__) && defined(__sparc__)
+      internal_memcpy (&globals[res], &g, sizeof (Global));
----------------
vitalybuka wrote:
> sizeof(g)
Changed.



================
Comment at: compiler-rt/lib/asan/asan_globals.cc:119
+#if defined(__GNUC__) && defined(__sparc__)
+      internal_memcpy (&globals[res], &g, sizeof (Global));
+#else
----------------
vitalybuka wrote:
> clang-format
Fixed.





Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58433/new/

https://reviews.llvm.org/D58433