[PATCH] D58433: AddressSanitizer: fix for SPARC with GCC
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 20 11:00:53 PST 2019
vitalybuka added inline comments.
================
Comment at: compiler-rt/lib/asan/asan_globals.cc:115
if (flags()->report_globals >= 2)
ReportGlobal(g, "Search");
----------------
Could you please upload patches with "arc" tool https://llvm.org/docs/Phabricator.html#subversion-and-arcanist-deprecated
Without it we have "Context not available."
================
Comment at: compiler-rt/lib/asan/asan_globals.cc:118
if (IsAddressNearGlobal(addr, g)) {
+#if defined(__GNUC__) && defined(__sparc__)
+ internal_memcpy (&globals[res], &g, sizeof (Global));
----------------
sizeof(g)
================
Comment at: compiler-rt/lib/asan/asan_globals.cc:119
+#if defined(__GNUC__) && defined(__sparc__)
+ internal_memcpy (&globals[res], &g, sizeof (Global));
+#else
----------------
clang-format
Repository:
rCRT Compiler Runtime
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58433/new/
https://reviews.llvm.org/D58433
More information about the llvm-commits
mailing list