[PATCH] D58481: [AMDGPU] fix commuted case of sub combine

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 17:46:45 PST 2019


rampitec planned changes to this revision.
rampitec added a comment.

Actually I think it is still wrong. In the commuted case carry must be added, not subtracted:

  x - (y - 0 - cc) => x - y + cc

I will just disable it for commuted case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58481/new/

https://reviews.llvm.org/D58481





More information about the llvm-commits mailing list