[PATCH] D34499: Expose __gcov_flush for parity with libgcov in the gcc project

[Enji Cooper via Phabricator via llvm-commits]

ngie marked 5 inline comments as done.
ngie added inline comments.


================
Comment at: compiler-rt/include/CMakeLists.txt:57
+  PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ
+  DESTINATION ${COMPILER_RT_INSTALL_PATH}/include)
+
----------------
vsk wrote:
> I've noticed that the sanitizer headers fall under a dedicated directory. Is it worth doing that for gcov (i.e. have <gcov/gcov.h>)?
For compatibility reasons, this header should be installed under a toolchain visible path (which compiler-rt provides).

Here's the path for gcc 8.2.0:
```
$ find /usr/local/ -name gcov.h
/usr/local/lib/gcc8/gcc/x86_64-portbld-freebsd13.0/8.2.0/include/gcov.h
```

The compiler-rt headers will be installed in `/usr/local/llvm80/lib/clang/8.0.0/include/` on FreeBSD for the third-party package.


================
Comment at: compiler-rt/include/gcov.h:7
+ * |* License. See LICENSE.TXT for details.
+ * |*
+ * |*===----------------------------------------------------------------------===*|
----------------
vsk wrote:
> There's a new llvm license now, and I think it applies here:
> ```
> |* Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
> |* See https://llvm.org/LICENSE.txt for license information.                       
> |* SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 
> ```
*nod!*


================
Comment at: compiler-rt/include/gcov.h:19-21
+ *  * - Write profile information/counters out to their appropriate GCDA files.
+ *   * - Reset profile counters to zero.
+ *    */
----------------
This seems like a mis-paste.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D34499/new/

https://reviews.llvm.org/D34499