[PATCH] D34499: Expose __gcov_flush for parity with libgcov in the gcc project
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 20 11:14:22 PST 2019
vsk added inline comments.
================
Comment at: compiler-rt/include/CMakeLists.txt:57
+ PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ
+ DESTINATION ${COMPILER_RT_INSTALL_PATH}/include)
+
----------------
I've noticed that the sanitizer headers fall under a dedicated directory. Is it worth doing that for gcov (i.e. have <gcov/gcov.h>)?
================
Comment at: compiler-rt/include/gcov.h:7
+ * |* License. See LICENSE.TXT for details.
+ * |*
+ * |*===----------------------------------------------------------------------===*|
----------------
There's a new llvm license now, and I think it applies here:
```
|* Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|* See https://llvm.org/LICENSE.txt for license information.
|* SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D34499/new/
https://reviews.llvm.org/D34499
More information about the llvm-commits
mailing list