[PATCH] D58113: [SCEV] Teach computeSCEVAtScope benefit from one-input Phi. PR39673
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 20 08:58:35 PST 2019
reames added a comment.
LGTM
I'm fine with this landing, since the patch is an obvious improvement. However, I have to admit I don't understand the interaction between LCSSA and SCEV here. Why does SCEV need to care that a phi might be a LCSSA phi? They seem orthogonal. Maybe *some particular caller* might need to care, but that seems like a different issue?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58113/new/
https://reviews.llvm.org/D58113
More information about the llvm-commits
mailing list