[PATCH] D57523: Fix uninitialized value in ABIArgInfo

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: jdoerfert.
Herald added a project: clang.

I've been staring at this, trying to figure out if the code somehow ends up using the uninitialized values, but I can't find it. So either it's hard to find, or GCC is doing something wrong.

But anyway, I think committing your change makes sense, but I think don't think we can say "Fix uninitialized value in ABIArgInfo", because it's not clear what needs fixing. Instead, I'd say "Always initialize the members in ABIArgInfo". That kind of makes sense in itself as it makes the code safer and possibly simpler, and of course it's also good that it fixes this problem.

What do you think?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57523/new/

https://reviews.llvm.org/D57523