[PATCH] D58170: [DTU] Refine the interface and logic of applyUpdates

[Chijun Sima via Phabricator via llvm-commits]

NutshellySima updated this revision to Diff 187564.
NutshellySima retitled this revision from "[DTU] Refine the logic of deduplication" to "[DTU] Refine the interface and logic of applyUpdates".
NutshellySima edited the summary of this revision.
NutshellySima added a comment.

1. Add explanations and examples on why the invalid updates removing code works.
2. Add the precondition that the order of an edge in Updates needs to be ordered as CFG changes were made.
3. Separate `applyUpdates` into `applyUpdatesAccurate` and `applyUpdatesHinted` to decouple different semantics of `applyUpdates` from `Eager/Lazy` mode and enable DTU(Lazy) to accept unordered accurate updates.

Summary is also updated to explain why and how logic and interface of applyUpdates changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58170/new/

https://reviews.llvm.org/D58170

Files:
  llvm/include/llvm/Analysis/DomTreeUpdater.h
  llvm/lib/Analysis/DomTreeUpdater.cpp
  llvm/lib/Transforms/Utils/BasicBlockUtils.cpp
  llvm/lib/Transforms/Utils/CloneFunction.cpp
  llvm/lib/Transforms/Utils/Local.cpp
  llvm/unittests/Analysis/DomTreeUpdaterTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58170.187564.patch
Type: text/x-patch
Size: 26104 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190220/aed63b61/attachment-0001.bin>