[PATCH] D58315: [WebAssembly] Add .shared directive for shared memory

[Thomas Lively via Phabricator via llvm-commits]

tlively marked an inline comment as done.
tlively added inline comments.


================
Comment at: llvm/lib/MC/WasmObjectWriter.cpp:756
+      if (Import.Memory.Flags & wasm::WASM_LIMITS_FLAG_HAS_MAX)
+        encodeULEB128(NumPages, W.OS);          // max
       break;
----------------
sbc100 wrote:
> I guess this makes sense for completeness, but an object file really doesn't make sense to have a max for its memory.
Yeah, unfortunately it is necessary if we want object files to validate. Also unfortunately, it is invalid to have the limits be shared but not have a max, so we have to just come up with some arbitrary max.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58315/new/

https://reviews.llvm.org/D58315