[PATCH] D58315: [WebAssembly] Add .shared directive for shared memory

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: llvm/lib/MC/WasmObjectWriter.cpp:756
+      if (Import.Memory.Flags & wasm::WASM_LIMITS_FLAG_HAS_MAX)
+        encodeULEB128(NumPages, W.OS);          // max
       break;
----------------
I guess this makes sense for completeness, but an object file really doesn't make sense to have a max for its memory.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58315/new/

https://reviews.llvm.org/D58315