[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: llvm/runtimes/CMakeLists.txt:220
+  get_property(LLVM_RUNTIMES GLOBAL PROPERTY LLVM_RUNTIMES)
+  export(TARGETS ${LLVM_RUNTIMES} FILE ${LLVM_RUNTIMES_FILE})
+
----------------
phosek wrote:
> smeenai wrote:
> > Why do we need to collect targets manually instead of just using the `export(EXPORT)` signature?
> I just followed what LLVM already does for `LLVMExports` but I'm fine using `export(EXPORT)` if that's preferred.
Yeah, the `export(EXPORT)` form should be equivalent here I think, and it should eliminate redundancies/prevent future divergences, so I'd prefer that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49587/new/

https://reviews.llvm.org/D49587