[PATCH] D58379: [compiler-rt] Intercept the bcmp() function.
Kamil Rytarowski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 19 01:44:35 PST 2019
krytarowski added a comment.
> <strings.h> should be included unconditionally.
Sorry, I've overlooked that this is `stringS.h`. Including `string.h`unconditionally is fine. The stringS form maybe is needed for GNU, it's on BSDs too as it's a legacy header, but NetBSD both work and `string.h` is preferred.
================
Comment at: lib/asan/tests/asan_mem_test.cc:248
+TEST(AddressSanitizer, BCmpOOBTest) {
+#ifdef _GNU_SOURCE
+ CmpOOBTestCommon<bcmp>();
----------------
`|| defined(__NetBSD__)`
Repository:
rCRT Compiler Runtime
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58379/new/
https://reviews.llvm.org/D58379
More information about the llvm-commits
mailing list