[PATCH] D58379: [compiler-rt] Intercept the bcmp() function.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 19 01:39:55 PST 2019


courbet added a comment.

In D58379#1401986 <https://reviews.llvm.org/D58379#1401986>, @krytarowski wrote:

> Please enable the tests for NetBSD as well.
>
> `<strings.h>` should be included unconditionally.


Just to make sure I understand (I'm not familiar with this code base):

- Will the tests in `Posix/` be compiled only for platforms supporting this ? Is that why `<strings.h>` can be included unconditionally ?
- `lib/asan/tests/asan_mem_test.cc` will be compiled for platforms without `<strings.h>`, right ?


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58379/new/

https://reviews.llvm.org/D58379





More information about the llvm-commits mailing list