[PATCH] D58117: Workaround std::thread begin not copy-constructible

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D58117#1401491 <https://reviews.llvm.org/D58117#1401491>, @serge-sans-paille wrote:

> In D58117#1401457 <https://reviews.llvm.org/D58117#1401457>, @dblaikie wrote:
>
> > There should be an rvalue overload of std::vector<T>::push_back - is there not? ( https://en.cppreference.com/w/cpp/container/vector/push_back )
>
>
> Right! https://godbolt.org/z/c3iMsT proves you right. The part that actually matters seems to be the ``construct`` member forwarding (why is inheritance not enough in that case?).


That failure appears only on trunk GCC/libstdc++, by the looks of it? Does it matter that Clang doesn't compile on an unreleased compiler? (8.2 seems to compile the example OK) I can't seem to find a convenient web view of the current libstdc++ sources, so I'm only guessing, but that might well be a bug in trunk libstdc++.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58117/new/

https://reviews.llvm.org/D58117