[PATCH] D58117: Workaround std::thread begin not copy-constructible
serge via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 18 13:06:37 PST 2019
serge-sans-paille added a comment.
In D58117#1401457 <https://reviews.llvm.org/D58117#1401457>, @dblaikie wrote:
> There should be an rvalue overload of std::vector<T>::push_back - is there not? ( https://en.cppreference.com/w/cpp/container/vector/push_back )
Right! https://godbolt.org/z/c3iMsT proves you right. The part that actually matters seems to be the ``construct`` member forwarding (why is inheritance not enough in that case?).
Repository:
rCRT Compiler Runtime
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58117/new/
https://reviews.llvm.org/D58117
More information about the llvm-commits
mailing list