[PATCH] D58312: [WebAssembly] Generalize section ordering constraints

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 15 19:53:35 PST 2019

sbc100 added a comment.

In D58312#1400234 <https://reviews.llvm.org/D58312#1400234>, @tlively wrote:

> In D58312#1400104 <https://reviews.llvm.org/D58312#1400104>, @sbc100 wrote:
> > When we discussed this before @binji and others argued that a total ordering made more sense.
> What made me think this was a good idea was that I discovered that yaml2obj was not respecting the total ordering in its output by emitting relocations after the producers section. Fixing the total ordering logic to selectively ignore the producers section in some contexts seemed hacky and changing the yaml2obj logic seemed like letting section ordering complexity creep into unrelated code. That being said, I don't want to rehash old conversations pointlessly, so I'm happy to fix yaml2obj instead of making this change if that's what people want.

I think I argued for doing it this way at the time too, I'm just making sure that we get buy in from those who argued for the total ordering before making this change.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list