[PATCH] D58296: [llvm-objcopy] Make removeSectionReferences batched

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 15 19:15:46 PST 2019


MaskRay added a comment.

The approach looks good to me, but is anyone concerned about the 3MB compressed file?



================
Comment at: llvm/tools/llvm-objcopy/ELF/Object.h:340
+  Error
+  removeSectionReferences(const std::vector<const SectionBase *> &Sec) override;
   void initialize(SectionTableRef SecTable) override;
----------------
Do you consider a plural form? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58296/new/

https://reviews.llvm.org/D58296





More information about the llvm-commits mailing list