[PATCH] D58248: [EarlyCSE & MSSA] Cap the clobbering calls in EarlyCSE.
Alina Sbirlea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 15 13:38:14 PST 2019
asbirlea marked an inline comment as done.
asbirlea added inline comments.
================
Comment at: lib/Transforms/Scalar/EarlyCSE.cpp:1206
// Reset the current generation.
CurrentGeneration = LiveOutGeneration;
----------------
george.burgess.iv wrote:
> Should we be resetting `ClobberCounter` here, as well?
AFAICT `run()` is only invoked once for an EarlyCSE instance and it's not recursive.
I'm also missing the purpose of `CurrentGeneration = LiveOutGeneration;` and
the above
```
// Save the current generation.
unsigned LiveOutGeneration = CurrentGeneration;
```
Could you please clarify?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58248/new/
https://reviews.llvm.org/D58248
More information about the llvm-commits
mailing list