[PATCH] D58248: [EarlyCSE & MSSA] Cap the clobbering calls in EarlyCSE.

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv added a comment.

Thanks for doing this! Just two nits for you :)



================
Comment at: lib/Transforms/Scalar/EarlyCSE.cpp:672
+  MemoryAccess *LaterDef;
+  if (ClobberCounter < EarlyCSEMssaOptCap) {
+    LaterDef = MSSA->getWalker()->getClobberingMemoryAccess(LaterInst);
----------------
Please add a TODO with notes about moving this to MSSA and maybe the link to the motivating patch (https://reviews.llvm.org/D56720)


================
Comment at: lib/Transforms/Scalar/EarlyCSE.cpp:1206
   // Reset the current generation.
   CurrentGeneration = LiveOutGeneration;
 
----------------
Should we be resetting `ClobberCounter` here, as well?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58248/new/

https://reviews.llvm.org/D58248