[PATCH] D56587: Introduce DW_OP_LLVM_convert

[Markus Lavin via Phabricator via llvm-commits]

markus updated this revision to Diff 187015.
markus added a comment.

Addressed the inlined location expressions.

Got rid of all the label differences introduced in previous patches and instead use padded `ULEB128`s of a fixed size (4 bytes).

Using fixed size allows us to leverage the existing framework much better and avoid spraying symbols all over to place just to be able to cope with the variable sized `.uleb128` directives. One drawback is that debug output is perhaps slightly less space efficient but that is only a matter of a few bytes each time a `base_type` is referenced from a `DW_OP_convert`.

Comments please (I know that I need to add lit tests and clean up comments).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56587/new/

https://reviews.llvm.org/D56587

Files:
  docs/LangRef.rst
  include/llvm/BinaryFormat/Dwarf.h
  include/llvm/CodeGen/AsmPrinter.h
  include/llvm/CodeGen/DIE.h
  include/llvm/CodeGen/DIEValue.def
  include/llvm/MC/MCStreamer.h
  lib/AsmParser/LLParser.cpp
  lib/BinaryFormat/Dwarf.cpp
  lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp
  lib/CodeGen/AsmPrinter/ByteStreamer.h
  lib/CodeGen/AsmPrinter/DIE.cpp
  lib/CodeGen/AsmPrinter/DIEHash.cpp
  lib/CodeGen/AsmPrinter/DebugLocEntry.h
  lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  lib/CodeGen/AsmPrinter/DwarfCompileUnit.h
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.h
  lib/CodeGen/AsmPrinter/DwarfExpression.cpp
  lib/CodeGen/AsmPrinter/DwarfExpression.h
  lib/CodeGen/AsmPrinter/DwarfFile.h
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  lib/IR/AsmWriter.cpp
  lib/IR/DebugInfoMetadata.cpp
  lib/MC/MCStreamer.cpp
  lib/Target/BPF/MCTargetDesc/BPFAsmBackend.cpp
  lib/Transforms/Utils/Local.cpp
  test/Assembler/diexpression.ll
  test/Transforms/InstCombine/cast-set-preserve-signed-dbg-val.ll
  unittests/Transforms/Utils/LocalTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56587.187015.patch
Type: text/x-patch
Size: 38225 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190215/375d37d0/attachment.bin>