[PATCH] D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 marked an inline comment as done.
evgeny777 added inline comments.


================
Comment at: tools/llvm-objcopy/CopyConfig.cpp:486
+  if (auto *Arg = InputArgs.getLastArg(OBJCOPY_set_start)) {
+    unsigned long long EAddr;
+    getAsUnsignedInteger(Arg->getValue(), 0, EAddr);
----------------
rupprecht wrote:
> uint64_t
On 64 bit platforms uint64_t is `unsigned long`, not `unsigned long long`. You'll get the compilation error on x64 if you change type (x86 will be ok)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58173/new/

https://reviews.llvm.org/D58173