[PATCH] D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added inline comments.


================
Comment at: tools/llvm-objcopy/CopyConfig.cpp:486
+  if (auto *Arg = InputArgs.getLastArg(OBJCOPY_set_start)) {
+    unsigned long long EAddr;
+    getAsUnsignedInteger(Arg->getValue(), 0, EAddr);
----------------
uint64_t


================
Comment at: tools/llvm-objcopy/CopyConfig.cpp:492
+  if (auto *Arg = InputArgs.getLastArg(OBJCOPY_change_start)) {
+    long long EIncr;
+    getAsSignedInteger(Arg->getValue(), 0, EIncr);
----------------
int64_t


================
Comment at: tools/llvm-objcopy/CopyConfig.h:105
+  // Address expression options
+  std::function<uint64_t(uint64_t)> EntryExpr;
+
----------------
Can you use a more descriptive name/docs here?


================
Comment at: tools/llvm-objcopy/ObjcopyOpts.td:245
+                    MetaVarName<"incr">;
+def adjust_start : JoinedOrSeparate<["--"], "adjust-start">, Alias<change_start>;
----------------
Does this allow -adjust-start?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58173/new/

https://reviews.llvm.org/D58173