[PATCH] D58184: [scudo][standalone] Introduce platform specific code & mutexes

Roland McGrath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 14 10:12:09 PST 2019

mcgrathr added inline comments.

Comment at: lib/scudo/standalone/fuchsia.cc:131
+  } else {
+    _zx_handle_close(Vmo);
+  }
cryptoad wrote:
> dmmoore415 wrote:
> > Shouldn't you at least check and log a bad status here?
> I am going to have to defer to people who know more about the internals than I do: in which situations can closing a handle (or destroying a vmar) fail? Is it recoverable? Most of the code I see in musl for example doesn't check for that.
They should never fail.  If they do it's probably a bug somewhere so having a panic wouldn't hurt.  I think the only expected error cases for those are for a bad handle, which would indicate a bug in this code or some catastrophic clobberation.

  rCRT Compiler Runtime



More information about the llvm-commits mailing list