[PATCH] D58184: [scudo][standalone] Introduce platform specific code & mutexes

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 14 09:37:45 PST 2019


cryptoad marked an inline comment as not done.
cryptoad added inline comments.


================
Comment at: lib/scudo/standalone/fuchsia.cc:131
+  } else {
+    _zx_handle_close(Vmo);
+  }
----------------
dmmoore415 wrote:
> Shouldn't you at least check and log a bad status here?
I am going to have to defer to people who know more about the internals than I do: in which situations can closing a handle (or destroying a vmar) fail? Is it recoverable? Most of the code I see in musl for example doesn't check for that.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58184/new/

https://reviews.llvm.org/D58184





More information about the llvm-commits mailing list