[PATCH] D58073: [GlobalISel][NFC]: Add interface to reserve memory in GISelWorklist

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 13 13:30:30 PST 2019


paquette added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/GISelWorkList.h:70-72
+      if (!WorklistMap.try_emplace(Worklist[i], i).second) {
+        llvm_unreachable("Duplicate elements in the list");
+      }
----------------
Don't need braces here.


================
Comment at: include/llvm/CodeGen/GlobalISel/GISelWorkList.h:94
     auto It = WorklistMap.find(I);
     if (It == WorklistMap.end()) return; // Not in worklist.
 
----------------
I think that in standard LLVM code style, the return should be on a newline. (Or, that's what clang-format does on my end anyway)

```
if (It == WorklistMap.end())
    return;
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58073/new/

https://reviews.llvm.org/D58073





More information about the llvm-commits mailing list