[PATCH] D58073: [GlobalISel][NFC]: Add interface to reserve memory in GISelWorklist

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 13 13:13:07 PST 2019


arsenm added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/GISelWorkList.h:90
   void remove(const MachineInstr *I) {
+#ifndef NDEBUG
+    assert((Finalized || WorklistMap.empty()) && "Neither finalized nor empty");
----------------
This is redundant


================
Comment at: include/llvm/CodeGen/GlobalISel/GISelWorkList.h:108
   MachineInstr *pop_back_val() {
+#ifndef NDEBUG
+    assert(Finalized && "GISelWorkList used without finalizing");
----------------
Ditto


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58073/new/

https://reviews.llvm.org/D58073





More information about the llvm-commits mailing list