[PATCH] D55295: LiveIntervals: Add removePhysReg
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 13 10:45:37 PST 2019
arsenm marked an inline comment as done.
arsenm added inline comments.
================
Comment at: include/llvm/CodeGen/LiveIntervals.h:423
+ /// Reg. Subsequent uses should rely on on-demand recomputation.
+ void removePhysReg(unsigned Reg) {
+ for (MCRegUnitIterator Units(Reg, TRI); Units.isValid(); ++Units)
----------------
kparzysz wrote:
> Could this be called `removePhysRegUnits`? I think it would make it clearer what it actually does.
You are passing it a physreg, not a regunit so I think that would be more confusing. This is sort of hiding the implementation detail that the liveness of RegUnits is tracked
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55295/new/
https://reviews.llvm.org/D55295
More information about the llvm-commits
mailing list