[PATCH] D55295: LiveIntervals: Add removePhysReg

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 13 10:38:52 PST 2019


kparzysz added inline comments.


================
Comment at: include/llvm/CodeGen/LiveIntervals.h:423
+    /// Reg. Subsequent uses should rely on on-demand recomputation.
+    void removePhysReg(unsigned Reg) {
+      for (MCRegUnitIterator Units(Reg, TRI); Units.isValid(); ++Units)
----------------
Could this be called `removePhysRegUnits`?  I think it would make it clearer what it actually does.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55295/new/

https://reviews.llvm.org/D55295





More information about the llvm-commits mailing list