[PATCH] D58136: GlobalISel: Implement moreElementsVector for g_insert results

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:2370
+    Observer.changingInstr(MI);
+    moreElementsVectorSrc(MI, MoreTy, 1);
+    moreElementsVectorDst(MI, MoreTy, 0);
----------------
paquette wrote:
> Should we be asserting that the types are vectors for these? Or does it not matter?
These seem to allow any types.

One thing I'm sort of thinking about for some vector legalizations is if this is OK or sufficient.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58136/new/

https://reviews.llvm.org/D58136