[PATCH] D58136: GlobalISel: Implement moreElementsVector for g_insert results
Jessica Paquette via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 13 09:40:15 PST 2019
paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.
LGTM with question
================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:2370
+ Observer.changingInstr(MI);
+ moreElementsVectorSrc(MI, MoreTy, 1);
+ moreElementsVectorDst(MI, MoreTy, 0);
----------------
Should we be asserting that the types are vectors for these? Or does it not matter?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58136/new/
https://reviews.llvm.org/D58136
More information about the llvm-commits
mailing list