[PATCH] D58187: Teach DTU to recalculate DT/PDT automatically when EntryBB is changed

Brian Rzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 13 09:24:41 PST 2019

brzycki added a comment.

> recalculate() can be deprecated. But there are still edge cases, for example, when we only insert a new block to be the entry block or move a block up to be the entry block, it is still needed to call `flush()` to detect this change. (But I don't see usage like the above scenario I mentioned currently.)

If there are still edge cases then we need to keep it as a last-ditch method of resetting the `DTU` state without creating a new class instance. It might be a good idea to add documentation stating the interface isn't meant to be used except as a last-ditch fix that cannot be addressed by any other means.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list